-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rootfs dir #781
Fix rootfs dir #781
Conversation
@mthalman the build is failing during
I believe the kitware signing keys have been updated, but we are still using a cached base image with an older signing key, the one obtained here:
How would I go about updating the base images? (As a longer-term solution, it looks like there is a package that will keep signing keys updated - kitware-archive-keyring, mentioned here: https://apt.kitware.com/). |
@sbomer - If you make an arbitrary change to the base Dockerfile, it will trigger it to get rebuilt. Then you can revert your change. It's based off commit SHA, so it should still rebuild even after you revert your change. |
This reverts commit 5b95d32.
This reverts commit 7e69adf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this got you the build results you're looking for, go ahead and revert the crossdeps Dockerfile change.
This reverts commit 9ccff47.
This fixes the rootfs dir for the images added in #754, to be consistent with the existing images.
I looked for a way to extract this into a single variable in the Dockerfile. The only way I found was to use ENV, but that would persist the environment variable into the created image - and I want to avoid polluting the image's environment.