Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rootfs dir #781

Merged
merged 5 commits into from
Jan 27, 2023
Merged

Fix rootfs dir #781

merged 5 commits into from
Jan 27, 2023

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jan 26, 2023

This fixes the rootfs dir for the images added in #754, to be consistent with the existing images.

I looked for a way to extract this into a single variable in the Dockerfile. The only way I found was to use ENV, but that would persist the environment variable into the created image - and I want to avoid polluting the image's environment.

@sbomer
Copy link
Member Author

sbomer commented Jan 26, 2023

@mthalman the build is failing during apt-get update with:

W: GPG error: https://apt.kitware.com/ubuntu focal InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 42D5A192B819C5DA

I believe the kitware signing keys have been updated, but we are still using a cached base image with an older signing key, the one obtained here:

&& wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc | apt-key add - \

How would I go about updating the base images? (As a longer-term solution, it looks like there is a package that will keep signing keys updated - kitware-archive-keyring, mentioned here: https://apt.kitware.com/).

@mthalman
Copy link
Member

@sbomer - If you make an arbitrary change to the base Dockerfile, it will trigger it to get rebuilt. Then you can revert your change. It's based off commit SHA, so it should still rebuild even after you revert your change.

Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this got you the build results you're looking for, go ahead and revert the crossdeps Dockerfile change.

@mthalman mthalman merged commit b47a67b into dotnet:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants