Add runtime build dependencies to ubuntu 22.04 image #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @janvorli @jkoritzinsky |
jkoritzinsky
approved these changes
Apr 13, 2023
mthalman
approved these changes
Apr 13, 2023
|
@mthalman please merge when you have a chance. |
This was referenced Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These dependencies will let us use ubuntu 22.04 for non-cross builds in various ci scenarios:
libicu-dev.lldis required and will help fix the linux enterprise build mentioned in Build on CBL-mariner host with rootfs runtime#84148 (comment), if we can move that to ubuntu 22.04 as well. Ubuntu 22.04 installslld14 by default, so this will let us use the size optimization added by @am11 in Write linker script for lld to enable gc-sections runtime#84493.