Added some Dockerfiles for creating a .NET Core on Windows Server Core #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see my docker files are all wrong and I shouldn't have copy-pasted 😜 so I opened an issue for better discussion. |
|
Closing as we have no plans to support Windows Server Core based images. See discussion in #741. |
|
Gotcha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a nice small PR to add the initial bits to get a Windows Server Core image with .NET Core.
Not sure of the reason they don't exist, but I am sure someone will post a comment in a minute 😺
Anyway, this is very useful so I don't have to download an install the Core SDK each time on my images.
A practical use case is this issue: mono/SkiaSharp#591. As a result, I had to create a longer Dockerfile to first create a container, install .NET Core SDK, and then build my app, create a new container, install the Core Runtime and then run my app: https://gist.github.com/mattleibow/32ff6d124e7b5b93e94f1eb45d243aba
I don't mind installing the vc_redist at this point, as I only have to do it on the runtime container, and I hope to be removing this step, but I hope to be able to just pull the latest .NET Core image that can to font subsetting :)