Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable AspNetResponseStatusTest test #3746

Merged

Conversation

jander-msft
Copy link
Member

@jander-msft jander-msft commented Feb 21, 2023

Summary

Seems to no longer repo due to fixes in #2914

Example build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2119826&view=results

closes #2762

Release Notes Entry

@jander-msft jander-msft requested a review from a team as a code owner February 21, 2023 23:08
@jander-msft jander-msft merged commit e2dcea2 into dotnet:main Feb 21, 2023
@jander-msft jander-msft deleted the reenable-aspnetresponsestatustest branch February 21, 2023 23:48
@jander-msft
Copy link
Member Author

/backport to release/7.x

@jander-msft
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.x: https://github.com/dotnet/dotnet-monitor/actions/runs/4237899481

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/dotnet-monitor/actions/runs/4237900039

@github-actions
Copy link
Contributor

@jander-msft backporting to release/7.0 failed, the patch most likely resulted in conflicts.

Please backport manually using one of the below commands, followed by git am --continue once the merge conflict has been resolved.

PowerShell

(Invoke-WebRequest "https://github.com/dotnet/dotnet-monitor/commit/e2dcea254f497969eada72ee941c70d803454b1d.patch").Content | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch

Bash

curl -sSL "https://github.com/dotnet/dotnet-monitor/commit/e2dcea254f497969eada72ee941c70d803454b1d.patch" | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch

git am error output:

$ git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch changes.patch

Applying: Reenable AspNetResponseStatusTest test (#3746)
Using index info to reconstruct a base tree...
A	src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/OverlappingEventSourceTests.cs
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/OverlappingEventSourceTests.cs deleted in HEAD and modified in Reenable AspNetResponseStatusTest test (#3746). Version Reenable AspNetResponseStatusTest test (#3746) of src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/OverlappingEventSourceTests.cs left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Reenable AspNetResponseStatusTest test (#3746)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

schmittjoseph added a commit that referenced this pull request Mar 30, 2023
schmittjoseph added a commit that referenced this pull request Mar 30, 2023
github-actions bot pushed a commit that referenced this pull request Mar 30, 2023
github-actions bot pushed a commit that referenced this pull request Mar 30, 2023
schmittjoseph added a commit that referenced this pull request Mar 30, 2023
This reverts commit e2dcea2.

Co-authored-by: Joe Schmitt <1146681+schmittjoseph@users.noreply.github.com>
schmittjoseph added a commit that referenced this pull request Mar 30, 2023
This reverts commit e2dcea2.

Co-authored-by: Joe Schmitt <1146681+schmittjoseph@users.noreply.github.com>
schmittjoseph added a commit to schmittjoseph/dotnet-monitor that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverlappingEventSourceTests_AspNetResponseStatusTest fails often
2 participants