Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VS using repository SDK to build for latest TFM #4128

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

jander-msft
Copy link
Member

Summary

Manual backport of #4123 to release/7.x

Release Notes Entry

@jander-msft jander-msft added the backport Pull requests that are backports of another pull request label Apr 3, 2023
@ghost ghost added dependencies Pull requests that update a dependency file needs-review labels Apr 3, 2023
@jander-msft jander-msft requested a review from a team April 4, 2023 22:28
@ghost ghost removed the needs-review label Apr 5, 2023
@jander-msft jander-msft merged commit 5de80f0 into dotnet:release/7.x Apr 5, 2023
@jander-msft jander-msft deleted the backport-4123-to-7.x branch April 5, 2023 20:52
@jander-msft
Copy link
Member Author

/backport to release/7.1

@jander-msft
Copy link
Member Author

/backport to release/6.x

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Started backporting to release/7.1: https://github.com/dotnet/dotnet-monitor/actions/runs/4622751726

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Started backporting to release/6.x: https://github.com/dotnet/dotnet-monitor/actions/runs/4622752639

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

@jander-msft backporting to release/6.x failed, the patch most likely resulted in conflicts.

Please backport manually using one of the below commands, followed by git am --continue once the merge conflict has been resolved.

PowerShell

(Invoke-WebRequest "https://github.com/dotnet/dotnet-monitor/commit/5de80f07b05ec48d0f55c059a5fdb80001ae6af3.patch").Content | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch

Bash

curl -sSL "https://github.com/dotnet/dotnet-monitor/commit/5de80f07b05ec48d0f55c059a5fdb80001ae6af3.patch" | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch

git am error output:

$ git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch changes.patch

Applying: Allow VS using repository SDK to build for latest TFM (#4128)
Using index info to reconstruct a base tree...
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow VS using repository SDK to build for latest TFM (#4128)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

@jander-msft
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Started backporting to release/7.0: https://github.com/dotnet/dotnet-monitor/actions/runs/4622825101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull requests that are backports of another pull request dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants