Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update async usage to conform to analyzer rules #7238

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Update async usage to conform to analyzer rules #7238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Tests/Microsoft.Diagnostics.Monitoring.OpenApiGen.UnitTests/OpenApiGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ public OpenApiGeneratorTests(ITestOutputHelper outputHelper)
/// is the same that is generated from the dotnet-monitor binaries.
/// </summary>
[Fact]
public async Task BaselineDifferenceTest()
public async Task BaselineDifferenceTestAsync()
{
using FileStream stream = await GenerateDocumentAsync();
using StreamReader reader = new(stream);

// Renormalize line endings due to git checkout normalizing to the operating system preference.
string baselineContent = File.ReadAllText(OpenApiBaselinePath).Replace("\r\n", "\n");
string generatedContent = reader.ReadToEnd();
string generatedContent = await reader.ReadToEndAsync();

bool equal = string.Equals(baselineContent, generatedContent, StringComparison.Ordinal);
if (!equal)
Expand Down Expand Up @@ -91,7 +91,7 @@ public void BaselineIsValidTest()
/// Test that the generated OpenAPI document is valid.
/// </summary>
[Fact]
public async Task GeneratedIsValidTest()
public async Task GeneratedIsValidTestAsync()
{
using FileStream stream = await GenerateDocumentAsync();

Expand Down