Move some provider-facing tests to specifications

* Moved to specifications: ApiConsistency, MigrationsSqlGenerator,
  UpdateSqlGeneratorTestBase, ModelValidatorTestBase (and Relational)
* Rearranged migrations tests under Migrations folder
* Reorganized SqlGenerationHelperTest split to simple, separate
  RelationalSqlGenerationHelperTest and
  SqlServerSqlGenerationHelperTest
* Suppress warning for underscores in test names

Closes #11500

test/Directory.Build.props

@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <NoWarn>$(NoWarn);1591;xUnit1000;xUnit1003;xUnit1004;xUnit1010;xUnit1013;xUnit1026</NoWarn>
+    <NoWarn>$(NoWarn);CA1707;1591;xUnit1000;xUnit1003;xUnit1004;xUnit1010;xUnit1013;xUnit1026</NoWarn>
   </PropertyGroup>
 
 </Project>

test/EFCore.Relational.Specification.Tests/MigrationsInfrastructureTestBase.cs → test/EFCore.Relational.Specification.Tests/Migrations/MigrationsInfrastructureTestBase.cs

@@ -14,7 +14,7 @@
 using Xunit;
 
 // ReSharper disable InconsistentNaming
-namespace Microsoft.EntityFrameworkCore
+namespace Microsoft.EntityFrameworkCore.Migrations
 {
     public abstract class MigrationsInfrastructureTestBase<TFixture> : IClassFixture<TFixture>
         where TFixture : MigrationsInfrastructureFixtureBase, new()

test/EFCore.Relational.Specification.Tests/MigrationsTestBase.cs → test/EFCore.Relational.Specification.Tests/Migrations/MigrationsTestBase.cs

@@ -20,7 +20,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using Xunit;
 
-namespace Microsoft.EntityFrameworkCore
+namespace Microsoft.EntityFrameworkCore.Migrations
 {
     public abstract class MigrationsTestBase<TFixture> : IClassFixture<TFixture>
         where TFixture : MigrationsTestBase<TFixture>.MigrationsFixtureBase, new()

test/EFCore.Relational.Tests/Update/UpdateSqlGeneratorTestBase.cs → test/EFCore.Relational.Specification.Tests/Update/UpdateSqlGeneratorTestBase.cs

@@ -701,8 +701,7 @@ protected ModificationCommand CreateInsertCommand(bool identityKey = true, bool
                 columnModifications = columnModifications.Where(c => !c.IsWrite).ToArray();
             }
 
-            return new FakeModificationCommand(
-                "Ducks", Schema, new ParameterNameGenerator().GenerateNext, false, columnModifications);
+            return new ModificationCommand("Ducks", Schema, columnModifications, false);
         }
 
         protected ModificationCommand CreateUpdateCommand(bool isComputed = true, bool concurrencyToken = true)
@@ -736,8 +735,7 @@ protected ModificationCommand CreateUpdateCommand(bool isComputed = true, bool c
                     concurrencyProperty.GetTableColumnMappings().Single().TypeMapping, false, true, false, concurrencyToken, true)
             };
 
-            return new FakeModificationCommand(
-                "Ducks", Schema, new ParameterNameGenerator().GenerateNext, false, columnModifications);
+            return new ModificationCommand("Ducks", Schema, columnModifications, false);
         }
 
         protected ModificationCommand CreateDeleteCommand(bool concurrencyToken = true)
@@ -759,8 +757,7 @@ protected ModificationCommand CreateDeleteCommand(bool concurrencyToken = true)
                     concurrencyProperty.GetTableColumnMappings().Single().TypeMapping, false, false, false, concurrencyToken, true)
             };
 
-            return new FakeModificationCommand(
-                "Ducks", Schema, new ParameterNameGenerator().GenerateNext, false, columnModifications);
+            return new ModificationCommand("Ducks", Schema, columnModifications, false);
         }
 
         protected abstract TestHelpers TestHelpers { get; }

test/EFCore.Relational.Tests/Storage/RelationalSqlGenerationHelperTest.cs

@@ -1,11 +1,26 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System;
+using Xunit;
+
 namespace Microsoft.EntityFrameworkCore.Storage
 {
-    public class RelationalSqlGenerationHelperTest : SqlGenerationHelperTestBase
+    public class RelationalSqlGenerationHelperTest
     {
-        protected override ISqlGenerationHelper CreateSqlGenerationHelper()
+        [ConditionalFact]
+        public void GenerateParameterName_returns_parameter_name()
+            => Assert.Equal("@name", CreateSqlGenerationHelper().GenerateParameterName("name"));
+
+        [ConditionalFact]
+        public void Default_BatchCommandSeparator_is_semicolon()
+            => Assert.Equal(";", CreateSqlGenerationHelper().StatementTerminator);
+
+        [ConditionalFact]
+        public void BatchSeparator_returns_separator()
+            => Assert.Equal(Environment.NewLine, CreateSqlGenerationHelper().BatchTerminator);
+
+        private ISqlGenerationHelper CreateSqlGenerationHelper()
             => new RelationalSqlGenerationHelper(new RelationalSqlGenerationHelperDependencies());
     }
 }

test/EFCore.SqlServer.FunctionalTests/MigrationsInfrastructureSqlServerTest.cs → test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsInfrastructureSqlServerTest.cs

@@ -16,7 +16,7 @@
 using Xunit;
 
 // ReSharper disable InconsistentNaming
-namespace Microsoft.EntityFrameworkCore
+namespace Microsoft.EntityFrameworkCore.Migrations
 {
     [SqlServerCondition(SqlServerCondition.IsNotSqlAzure | SqlServerCondition.IsNotCI)]
     public class MigrationsInfrastructureSqlServerTest

test/EFCore.SqlServer.FunctionalTests/MigrationsSqlServerTest.cs → test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsSqlServerTest.cs

@@ -19,7 +19,7 @@
 
 #nullable enable
 
-namespace Microsoft.EntityFrameworkCore
+namespace Microsoft.EntityFrameworkCore.Migrations
 {
     public class MigrationsSqlServerTest : MigrationsTestBase<MigrationsSqlServerTest.MigrationsSqlServerFixture>
     {

test/EFCore.SqlServer.Tests/Storage/SqlServerSqlGenerationHelperTest.cs

@@ -7,14 +7,13 @@
 
 namespace Microsoft.EntityFrameworkCore.Storage
 {
-    public class SqlServerSqlGenerationHelperTest : SqlGenerationHelperTestBase
+    public class SqlServerSqlGenerationHelperTest
     {
-        public override void BatchSeparator_returns_separator()
-        {
-            Assert.Equal("GO" + Environment.NewLine + Environment.NewLine, CreateSqlGenerationHelper().BatchTerminator);
-        }
+        [ConditionalFact]
+        public void BatchSeparator_returns_separator()
+            => Assert.Equal("GO" + Environment.NewLine + Environment.NewLine, CreateSqlGenerationHelper().BatchTerminator);
 
-        protected override ISqlGenerationHelper CreateSqlGenerationHelper()
+        private ISqlGenerationHelper CreateSqlGenerationHelper()
             => new SqlServerSqlGenerationHelper(new RelationalSqlGenerationHelperDependencies());
     }
 }

test/EFCore.Sqlite.FunctionalTests/MigrationsInfrastructureSqliteTest.cs → test/EFCore.Sqlite.FunctionalTests/Migrations/MigrationsInfrastructureSqliteTest.cs

@@ -11,7 +11,7 @@
 using ModelSnapshot22;
 using Xunit;
 
-namespace Microsoft.EntityFrameworkCore
+namespace Microsoft.EntityFrameworkCore.Migrations
 {
     public class MigrationsInfrastructureSqliteTest
         : MigrationsInfrastructureTestBase<MigrationsInfrastructureSqliteTest.MigrationsInfrastructureSqliteFixture>

test/EFCore.Sqlite.FunctionalTests/MigrationsSqliteTest.cs → test/EFCore.Sqlite.FunctionalTests/Migrations/MigrationsSqliteTest.cs

@@ -16,7 +16,7 @@
 
 #nullable enable
 
-namespace Microsoft.EntityFrameworkCore
+namespace Microsoft.EntityFrameworkCore.Migrations
 {
     public class MigrationsSqliteTest : MigrationsTestBase<MigrationsSqliteTest.MigrationsSqliteFixture>
     {

test/EFCore.Sqlite.Tests/SqliteMigrationBuilderTest.cs → test/EFCore.Sqlite.Tests/Migrations/SqliteMigrationBuilderTest.cs

@@ -4,7 +4,7 @@
 using Microsoft.EntityFrameworkCore.Migrations;
 using Xunit;
 
-namespace Microsoft.EntityFrameworkCore
+namespace Microsoft.EntityFrameworkCore.Migrations
 {
     public class SqliteMigrationBuilderTest
     {