Minor fixes to SQL baseline rewriter

dotnet · Dec 15, 2024 · ca0a58c · ca0a58c
1 parent 3d40dc3
commit ca0a58c
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/test/EFCore.Relational.Specification.Tests/TestUtilities/TestSqlLoggerFactory.cs b/test/EFCore.Relational.Specification.Tests/TestUtilities/TestSqlLoggerFactory.cs
@@ -159,7 +159,9 @@ void RewriteSourceWithNewBaseline(string fileName, int lineNumber)
                     using (var stream = File.OpenRead(fileName))
                     using (var bufferedStream = new BufferedStream(stream))
                     {
-                        syntaxTree = CSharpSyntaxTree.ParseText(SourceText.From(bufferedStream));
+                        syntaxTree = CSharpSyntaxTree.ParseText(
+                            SourceText.From(bufferedStream),
+                            new CSharpParseOptions(preprocessorSymbols: ["DEBUG"]));
                     }
 
                     // Read through the source file, copying contents to a temp file (with the baseline change)
@@ -278,14 +280,13 @@ void RewriteSourceWithNewBaseline(string fileName, int lineNumber)
                             writer.Write(tempBuf, 0, c);
                         }
                     }
+
+                    File.Move(fileName + ".tmp", fileName, overwrite: true);
                 }
-                catch
+                finally
                 {
                     File.Delete(fileName + ".tmp");
-                    throw;
                 }
-
-                File.Move(fileName + ".tmp", fileName, overwrite: true);
             }
         }
     }