Query: NRE when projecting non-mapped property from SelectMany

[maumar]

query:

cs.SelectMany(c => c.Orders.Select(o => new { OrderProperty = o.ShipName, CustomerProperty = c.ContactName }))

exception:

 Message: 
    System.NullReferenceException : Object reference not set to an instance of an object.
  Stack Trace: 
    at MemberAccessShiftingExpressionVisitor.VisitExtension(Expression node) in QueryableMethodTranslatingExpressionVisitor.cs line: 511
    at Expression.Accept(ExpressionVisitor visitor)
    at ExpressionVisitor.Visit(Expression node)
    at EntityShaperExpression.VisitChildren(ExpressionVisitor visitor) in EntityShaperExpression.cs line: 25
    at ExpressionVisitor.VisitExtension(Expression node)
    at MemberAccessShiftingExpressionVisitor.VisitExtension(Expression node) in QueryableMethodTranslatingExpressionVisitor.cs line: 517
    at Expression.Accept(ExpressionVisitor visitor)
    at ExpressionVisitor.Visit(Expression node)
    at ExpressionVisitor.VisitMember(MemberExpression node)
    at MemberExpression.Accept(ExpressionVisitor visitor)
    at ExpressionVisitor.Visit(Expression node)
    at ExpressionVisitorUtils.VisitArguments(ExpressionVisitor visitor, IArgumentProvider nodes)
    at ExpressionVisitor.VisitNew(NewExpression node)
    at NewExpression.Accept(ExpressionVisitor visitor)
    at ExpressionVisitor.Visit(Expression node)
    at QueryableMethodTranslatingExpressionVisitor.CombineShapers(Expression queryExpression, Expression outerShaper, Expression innerShaper, Type transparentIdentifierType) in QueryableMethodTranslatingExpressionVisitor.cs line: 489
    at QueryableMethodTranslatingExpressionVisitor.TranslateResultSelectorForJoin(ShapedQueryExpression outer, LambdaExpression resultSelector, Expression innerShaper, Type transparentIdentifierType) in QueryableMethodTranslatingExpressionVisitor.cs line: 459
    at RelationalQueryableMethodTranslatingExpressionVisitor.TranslateSelectMany(ShapedQueryExpression source, LambdaExpression collectionSelector, LambdaExpression resultSelector) in RelationalQueryableMethodTranslatingExpressionVisitor.cs line: 778
    at QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in QueryableMethodTranslatingExpressionVisitor.cs line: 351
    at RelationalQueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in RelationalQueryableMethodTranslatingExpressionVisitor.cs line: 72
    at MethodCallExpression.Accept(ExpressionVisitor visitor)
    at ExpressionVisitor.Visit(Expression node)
    at QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in QueryableMethodTranslatingExpressionVisitor.cs line: 58
    at RelationalQueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in RelationalQueryableMethodTranslatingExpressionVisitor.cs line: 72
    at MethodCallExpression.Accept(ExpressionVisitor visitor)
    at ExpressionVisitor.Visit(Expression node)
    at QueryCompilationContext.CreateQueryExecutor[TResult](Expression query) in QueryCompilationContext.cs line: 68
    at Database.CompileQuery[TResult](Expression query, Boolean async) in Database.cs line: 71
    at QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Boolean async) in QueryCompiler.cs line: 106
    at <>c__DisplayClass12_0`1.<ExecuteAsync>b__0() in QueryCompiler.cs line: 137
    at CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func`1 compiler) in CompiledQueryCache.cs line: 84
    at CompiledQueryCache.GetOrAddQuery[TResult](Object cacheKey, Func`1 compiler) in CompiledQueryCache.cs line: 59
    at QueryCompiler.ExecuteAsync[TResult](Expression query, CancellationToken cancellationToken) in QueryCompiler.cs line: 133
    at EntityQueryProvider.ExecuteAsync[TResult](Expression expression, CancellationToken cancellationToken) in EntityQueryProvider.cs line: 98
    at EntityQueryable`1.GetAsyncEnumerator(CancellationToken cancellationToken) in EntityQueryable`.cs line: 112
    at ConfiguredCancelableAsyncEnumerable`1.GetAsyncEnumerator()
    at EntityFrameworkQueryableExtensions.ToListAsync[TSource](IQueryable`1 source, CancellationToken cancellationToken) in EntityFrameworkQueryableExtensions.cs line: 2019
    at EntityFrameworkQueryableExtensions.ToArrayAsync[TSource](IQueryable`1 source, CancellationToken cancellationToken) in EntityFrameworkQueryableExtensions.cs line: 2050
    at QueryAsserter`1.AssertQuery[TItem1](Func`2 actualQuery, Func`2 expectedQuery, Func`2 elementSorter, Action`2 elementAsserter, Boolean assertOrder, Int32 entryCount, Boolean isAsync, String testMethodName) in QueryAsserter.cs line: 350
    at SimpleQuerySqlServerTest.SelectMany_with_collection_being_correlated_subquery_which_references_non_mapped_properties_from_inner_and_outer_entity(Boolean isAsync) in SimpleQuerySqlServerTest.Select.cs line: 1085
    at --- End of stack trace from previous location where exception was thrown ---

projectionBindingExpression.ProjectionMember is null

[divega]

@maumar to check if this affects simpler queries.

[smitpatel]

This would happen when running Join translation after one side has client eval. We should throw appropriately in advance.

[maumar]

i verified simple projection works