Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to map a CLR method returning queryable to TVF #20051

Closed
10 tasks done
smitpatel opened this issue Feb 25, 2020 · 2 comments · Fixed by #21507
Closed
10 tasks done

Ability to map a CLR method returning queryable to TVF #20051

smitpatel opened this issue Feb 25, 2020 · 2 comments · Fixed by #21507
Assignees
Labels
area-model-building area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Milestone

Comments

@smitpatel
Copy link
Member

smitpatel commented Feb 25, 2020

Split off from #4319

            public IQueryable<OrderByYear> GetCustomerOrderCountByYear(int customerId)
            {
                return CreateQuery(() => GetCustomerOrderCountByYear(customerId));
            }

Above when used in LINQ will insert query root for OrderByYear alongwith TVF as SQL translation.

It also bootstrappable. So you don't need to create query root.

Pending items

@smitpatel smitpatel added this to the 5.0.0 milestone Feb 25, 2020
@smitpatel smitpatel self-assigned this Feb 25, 2020
@smitpatel smitpatel linked a pull request Feb 25, 2020 that will close this issue
@AndriySvyryd AndriySvyryd linked a pull request Feb 25, 2020 that will close this issue
@AndriySvyryd AndriySvyryd self-assigned this Feb 25, 2020
AndriySvyryd added a commit that referenced this issue Feb 27, 2020
Allow to create functions without a method

Part of #20051
AndriySvyryd added a commit that referenced this issue Feb 27, 2020
Allow to create functions without a method

Part of #20051
AndriySvyryd added a commit that referenced this issue Feb 27, 2020
Allow to create functions without a method

Part of #20051
AndriySvyryd added a commit that referenced this issue Feb 27, 2020
Allow to create functions without a method

Part of #20051
AndriySvyryd added a commit that referenced this issue Feb 27, 2020
Allow to create functions without a method
Remove support for functions with expression parameters

Part of #20051
AndriySvyryd added a commit that referenced this issue Feb 27, 2020
Allow to create functions without a method
Remove support for functions with expression parameters

Part of #20051
AndriySvyryd added a commit that referenced this issue Feb 28, 2020
Allow to create functions without a method
Remove support for functions with expression parameters

Part of #20051
@roji
Copy link
Member

roji commented Mar 3, 2020

Adding providers-beware for the tests

@smitpatel
Copy link
Member Author

Don't leak DbContext in query cache for queryable functions.

AndriySvyryd added a commit that referenced this issue Mar 27, 2020
…nction.

Store mapped EntityType in the DbFunction.
Extract InternalDbFunctionBuilder and InternalDbFunctionParameterBuilder from DbFunctionBuilder and DbFunctionParameterBuilder.
Add more conditions to metadata API consistency test.

Part of #20051
Fixes #20160
AndriySvyryd added a commit that referenced this issue Mar 27, 2020
…nction.

Store mapped EntityType in the DbFunction.
Extract InternalDbFunctionBuilder and InternalDbFunctionParameterBuilder from DbFunctionBuilder and DbFunctionParameterBuilder.
Add more conditions to metadata API consistency test.

Part of #20051
Fixes #20160
AndriySvyryd added a commit that referenced this issue Mar 27, 2020
…nction.

Store mapped EntityType in the DbFunction.
Extract InternalDbFunctionBuilder and InternalDbFunctionParameterBuilder from DbFunctionBuilder and DbFunctionParameterBuilder.
Add more conditions to metadata API consistency test.

Part of #20051
Fixes #20160
AndriySvyryd added a commit that referenced this issue Jun 26, 2020
AndriySvyryd added a commit that referenced this issue Jun 30, 2020
AndriySvyryd added a commit that referenced this issue Jun 30, 2020
@AndriySvyryd AndriySvyryd removed their assignment Jun 30, 2020
AndriySvyryd added a commit that referenced this issue Jul 1, 2020
AndriySvyryd added a commit that referenced this issue Jul 3, 2020
AndriySvyryd added a commit that referenced this issue Jul 3, 2020
ghost pushed a commit that referenced this issue Jul 3, 2020
smitpatel added a commit that referenced this issue Jul 3, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 3, 2020
smitpatel added a commit that referenced this issue Jul 3, 2020
@ghost ghost closed this as completed in #21507 Jul 3, 2020
ghost pushed a commit that referenced this issue Jul 3, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview8 Jul 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-model-building area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Projects
None yet
4 participants