Generated JOIN for multiple MIN is wrong

[fschick]

Generated JOIN for multiple MIN is wrong

When multiple MIN are used, the translated ON clause of subsequent JOINs is wrong

The following query:

var timSheets = await dbContext
    .Set<TimeSheet>()
    .Where(x => x.OrderId != null)
    .GroupBy(x => x.OrderId)
    .Select(x => new
    {
        HourlyRate = x.Min(f => f.Order.HourlyRate),
        CustomerId = x.Min(f => f.Project.Customer.Id),
        CustomerName = x.Min(f => f.Project.Customer.Name),
    })
    .ToListAsync();

Is translated to:

SELECT MIN("o"."HourlyRate") AS "HourlyRate",
	MIN("c"."Id") AS "CustomerId",
	MIN("c0"."Name") AS "CustomerName"
FROM "TimeSheet" AS "t"
LEFT JOIN "Order" AS "o" ON "t"."OrderId" = "o"."Id"
INNER JOIN "Project" AS "p" ON "t"."ProjectId" = "p"."Id"
INNER JOIN "Customer" AS "c" ON "p"."CustomerId" = "c"."Id"
INNER JOIN "Project" AS "p0" ON "t"."ProjectId" = "p"."Id" -- <== THIS SHOULD BE ... = "p0"."Id"
INNER JOIN "Customer" AS "c0" ON "p0"."CustomerId" = "c"."Id" -- <== THIS SHOULD BE ... = "c0"."Id"
WHERE "t"."OrderId" IS NOT NULL
GROUP BY "t"."OrderId"

The generated ON clause for "p0" and "c0" produces a cartesian product.

See WhenGroupWithMinIsUsed_CustomerIdAndTitleMatches to reproduce

Code to reproduce

git clone https://github.com/fschick/EF.GeneratedSelectBug.git
cd EF.GeneratedSelectBug
dotnet test

Provider and version information

EF Core version: 6.0.1
Database provider: at least Microsoft.EntityFrameworkCore.SqlServer and Microsoft.EntityFrameworkCore.Sqlite
Target framework: .NET 6.0
Operating system: All
IDE: All