Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do full null semantics analysis on the subquery's projection column in InExpression #32850

Closed
roji opened this issue Jan 17, 2024 · 0 comments
Closed

Do full null semantics analysis on the subquery's projection column in InExpression #32850

roji opened this issue Jan 17, 2024 · 0 comments
Assignees
@roji
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
9.0.0

Comments

@roji
Copy link
Member

roji commented Jan 17, 2024

We currently only do a superficial check to see if the subquery projection is a column; if it's a more complex expression, we give up and assume it's nullable.
@roji roji added type-enhancement closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. area-query labels Jan 17, 2024
@roji roji self-assigned this Jan 17, 2024
roji added a commit to roji/efcore that referenced this issue Jan 17, 2024
@roji
Bubble up nullability for IN+subquery in SqlNullabilityProcessor
0ebde2d 
Fixes dotnet#32850
@ajcvickers ajcvickers added this to the 9.0.0 milestone Jan 17, 2024
roji added a commit to roji/efcore that referenced this issue Jan 22, 2024
@roji
Bubble up nullability for IN+subquery in SqlNullabilityProcessor
cc72bdc 
Fixes dotnet#32850
@roji roji closed this as completed in 1e01964 Jan 22, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
@roji roji modified the milestones: 9.0.0-preview1, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @roji