Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate shorter UnsafeAccessor names #33470

Closed
AndriySvyryd opened this issue Apr 4, 2024 · 2 comments · Fixed by #34146
Closed

Generate shorter UnsafeAccessor names #33470

AndriySvyryd opened this issue Apr 4, 2024 · 2 comments · Fixed by #34146
Labels
area-aot closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
9.0.0

Comments

@AndriySvyryd
Copy link
Member

See #33409 (comment)
@roji
Copy link
Member

roji commented Apr 12, 2024

@AndriySvyryd does this apply to both my mechanism (in LinqToCSharpTranslator) and to your mechanism for the generation of the compiled model?

@AndriySvyryd
Copy link
Member Author

Yes, we should be consistent

@AndriySvyryd AndriySvyryd added this to the 9.0.0 milestone Jun 20, 2024
@AndriySvyryd AndriySvyryd assigned AndriySvyryd and unassigned roji Jul 3, 2024
AndriySvyryd added a commit that referenced this issue Jul 3, 2024
@AndriySvyryd
Add UnsafeAccessor support for generic types
a7b0cb1 
Group UnsafeAccessor methods by target type
Generate fully qualified lambda signatures
Generate shorter UnsafeAccessor names
Reenable test code that uses the compiled model
Don't use Roslyn Formatter or Simplifier to make generation faster and avoid artifacts

Fixes #33773
Fixes #33470
Fixes #34057
@AndriySvyryd AndriySvyryd mentioned this issue Jul 3, 2024
Merged
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 3, 2024
@AndriySvyryd AndriySvyryd removed their assignment Jul 3, 2024
AndriySvyryd added a commit that referenced this issue Jul 3, 2024
@AndriySvyryd
Add UnsafeAccessor support for generic types
1af8af3 
Group UnsafeAccessor methods by target type
Generate fully qualified lambda signatures
Generate shorter UnsafeAccessor names
Reenable test code that uses the compiled model
Don't use Roslyn Formatter or Simplifier to make generation faster and avoid artifacts

Fixes #33773
Fixes #33470
Fixes #34057
AndriySvyryd added a commit that referenced this issue Jul 3, 2024
@AndriySvyryd
Add UnsafeAccessor support for generic types
1c1e19e 
Group UnsafeAccessor methods by target type
Generate fully qualified lambda signatures
Generate shorter UnsafeAccessor names
Reenable test code that uses the compiled model
Don't use Roslyn Formatter or Simplifier to make generation faster and avoid artifacts

Fixes #33773
Fixes #33470
Fixes #34057
AndriySvyryd added a commit that referenced this issue Jul 8, 2024
@AndriySvyryd
Add UnsafeAccessor support for generic types
7cb0b4d 
Group UnsafeAccessor methods by target type
Generate fully qualified lambda signatures
Generate shorter UnsafeAccessor names
Reenable test code that uses the compiled model
Don't use Roslyn Formatter or Simplifier to make generation faster and avoid artifacts

Fixes #33773
Fixes #33470
Fixes #34057
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview7 Aug 21, 2024
@roji roji modified the milestones: 9.0.0-preview7, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-aot closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Add UnsafeAccessor support for generic types dotnet/efcore
3 participants
@ajcvickers @roji @AndriySvyryd