Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change of entity type from owned to non-owned does not trigger conventions #34244

Closed
ajcvickers opened this issue Jul 18, 2024 · 0 comments · Fixed by #34343
Closed

Change of entity type from owned to non-owned does not trigger conventions #34244

ajcvickers opened this issue Jul 18, 2024 · 0 comments · Fixed by #34343
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
9.0.0

Comments

@ajcvickers
Copy link
Contributor

Repro: Can_create_relationship_if_navigations_have_same_name fails if IModelFinalizingConvention is removed.

Verified that nothing gets fired from the dispatcher when the last line of explicit configuration is executed.
@ajcvickers ajcvickers mentioned this issue Jul 18, 2024
Merged
@AndriySvyryd AndriySvyryd added this to the 9.0.0 milestone Aug 2, 2024
AndriySvyryd added a commit that referenced this issue Aug 2, 2024
@AndriySvyryd
Don't implement IModelFinalizingConvention on CosmosJsonIdConvention
d58283d 
Fixes #34244
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 2, 2024
@AndriySvyryd AndriySvyryd removed their assignment Aug 2, 2024
@AndriySvyryd AndriySvyryd mentioned this issue Aug 2, 2024
Merged
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-rc1 Aug 21, 2024
@roji roji modified the milestones: 9.0.0-rc1, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Don't implement IModelFinalizingConvention on CosmosJsonIdConvention dotnet/efcore
3 participants
@ajcvickers @roji @AndriySvyryd