Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete_FromSql_converted_to_subquery not discovered by xunit #34301

Closed
ChrisJollyAU opened this issue Jul 27, 2024 · 0 comments · Fixed by #34326
Closed

Delete_FromSql_converted_to_subquery not discovered by xunit #34301

ChrisJollyAU opened this issue Jul 27, 2024 · 0 comments · Fixed by #34326
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-bug
Milestone
9.0.0

Comments

@ChrisJollyAU
Copy link
Contributor

Picked this up as part of working on a provider

In my NorthwindBulkUpdatesJetTest test class, the test function Delete_FromSql_converted_to_subquery kept on not being discovered.

The function was definitely there and overriding the base from NorthwindBulkUpdatesRelationalTestBase

Tracing it back it looks like the base function has a missing

[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]

In #34257 you can See in the original NorthwindBulkUpdatesTestBase file https://github.com/dotnet/efcore/pull/34257/files#diff-291274a6719c975f624f35fb5e20b8587693f4e78226da36ae945abd26735682L279 the function had those attributes

But in the new NorthwindBulkUpdatesRelationalTestBase those attributes have been missed https://github.com/dotnet/efcore/pull/34257/files#diff-9b4e768ee8c57b32e13d0c399f2b201890e1aa8b228615016f5df8a093f771d9R35

Its a simple fix. I can do a pull request to add those 2 lines in
@ChrisJollyAU ChrisJollyAU mentioned this issue Jul 31, 2024
Merged
@ajcvickers ajcvickers added this to the 9.0.0 milestone Aug 1, 2024
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 1, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-rc1 Aug 21, 2024
@roji roji modified the milestones: 9.0.0-rc1, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-bug
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Add missing ConditionalTheory Attribute to Delete_FromSql_converted_to_subquery ChrisJollyAU/efcore
4 participants
@ajcvickers @maumar @roji @ChrisJollyAU