Move ExecuteUpdate/ExecuteDelete to core so non-relational providers can implement #34257
Conversation
|
/cc @damieng |
| case nameof(EntityFrameworkQueryableExtensions.ExecuteDeleteAsync): | ||
| case nameof(EntityFrameworkQueryableExtensions.ExecuteUpdate): | ||
| case nameof(EntityFrameworkQueryableExtensions.ExecuteUpdateAsync): | ||
| return ProcessUnknownMethod(methodCallExpression); |
There was a problem hiding this comment.
We should implement proper nav expansion for ExecuteUpdate (see #32493), but this can be done separately in another PR (this doesn't make things any worse than the current situation, even if it doesn't make them better).
test/EFCore.InMemory.FunctionalTests/BulkUpdates/FiltersInheritanceBulkUpdatesInMemoryTest.cs
Outdated
Show resolved
Hide resolved
|
One more thought... We should follow the pattern of adding TranslateExecuteUpdate/Delete methods to QueryableMethodTranslatingExpresionVisitor, and dispatching to them from the big method dispatch like with the others. Rather than making them abtract like the others, we should just provide a default implementation that adds a specific error message "your provider does not support ExecuteUpdate/Delete" and returns null. Relational would simply override these methods rather than implementing its own special dispatch in VisitMethodCall (which should be removed). |
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
…can implement Fixes #31052
|
@roji I moved the dispatch to core. |
|
@roji Helps if I actually push the commit. |
| @@ -138,6 +138,32 @@ protected override Expression VisitExtension(Expression extensionExpression) | |||
| protected override Expression VisitMethodCall(MethodCallExpression methodCallExpression) | |||
| { | |||
| var method = methodCallExpression.Method; | |||
|
|
|||
| if (method.DeclaringType == typeof(EntityFrameworkQueryableExtensions)) | |||
There was a problem hiding this comment.
I'd just merge this into the block below, this would deduplicate the visitation, check for SQE, etc. (we check on the generic methods for each case anyway)
| { | ||
| var queryable = context.Set<OrderDetail>().FromSqlRaw( | ||
| NormalizeDelimitersInRawString( | ||
| @"SELECT [OrderID], [ProductID], [UnitPrice], [Quantity], [Discount] |
There was a problem hiding this comment.
nit: raw literal string (and below)
Fixes #31052