Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations: CreateTableBuilder<TColumns> Annotation(string name, object value) should accept object? instead #35281

Closed
maumar opened this issue Dec 6, 2024 · 1 comment · Fixed by #35297
Closed

Migrations: CreateTableBuilder<TColumns> Annotation(string name, object value) should accept object? instead #35281

maumar opened this issue Dec 6, 2024 · 1 comment · Fixed by #35297
Assignees
@maumar
Labels
area-migrations closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
10.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Dec 6, 2024

Tiny NRT issue. OperationBuilder<TOperation> Annotation already does the right thing. We should be consistent.
@maumar maumar self-assigned this Dec 6, 2024
@maumar
Copy link
Contributor Author

maumar commented Dec 6, 2024

note to self: when fixed, also remove ! from tests

maumar added a commit that referenced this issue Dec 9, 2024
@maumar
Fix to #35281 - Migrations: CreateTableBuilder<TColumns> Annotation(s…
f959265 
…tring name, object value) should accept object? instead

Fixes #35281
@maumar maumar mentioned this issue Dec 9, 2024
Merged
@maumar maumar added this to the 10.0.0 milestone Dec 9, 2024
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 9, 2024
@maumar maumar closed this as completed in 4f423a0 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-migrations closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
10.0.0
1 participant
@maumar