fixed precompiled query not returning a result for a different inmemo… #13503
Conversation
|
|
|
can you please elaborate whats wrong with name matching? all tests are green? |
|
@JanEggers It's a mechanism that allows a database to be used across multiple service providers when this is opted into. But it is not universally safe sine two entity types could have the same name but have different underlying shapes. |
|
the database is still maintened by the store in the internal serviceprovider (identified by the magic name provided when calling UseInMemoryDatabase). with the change it is just possible to find the correct tables even if the entity types are not ref equal. can you please create a testcase that my fix may not violate. because like this it is quite hard for me to reason about what is valid and what is not |
|
@JanEggers Sure, I'll write a test when I get a chance. |
…nt in memory database - locate inmemory tables by entitytype.toString() - removed option useNameMatching as the new method works for all scenarios fixes dotnet#13483
|
Created an issue to track the test mentioned above; closing this PR as we don't intend to merge it. |
…ry database
fixed compiled queries not returning a result when applied to different in memory database
fixes #13483