API review changes #16357
Merged
API review changes #16357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #15662
ajcvickers
commented
Jun 30, 2019
| @@ -41,7 +41,7 @@ public static string GetDefaultTableName([NotNull] this IEntityType entityType) | |||
| return ownership.PrincipalEntityType.GetTableName(); | |||
| } | |||
|
|
|||
| return IdentifierHelpers.Truncate( | |||
| return Uniquifier.Truncate( | |||
There was a problem hiding this comment.
Any other ideas here?
There was a problem hiding this comment.
I'll defer to @AndriySvyryd...
ajcvickers
requested review from
AndriySvyryd and
bricelam
and removed request for
AndriySvyryd
bricelam
approved these changes
Jun 30, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #15662