Added the ability to log query parameters #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -462,6 +462,9 @@ | |||
| <data name="NavigationToSelfDuplicate" xml:space="preserve"> | |||
| <value>The navigation property '{navigation}' cannot be used for both ends of the relationship. Either specify it on the principal side or the dependent side.</value> | |||
| </data> | |||
| <data name="DebugLogWarning" xml:space="preserve"> | |||
| <value>Debug level logging is enabled. At this level, Entity Framework will log sensitive application data such as Sql parameter values. To hide this information configure ILoggerFactory.MinimumLevel to LogLevel.Verbose</value> | |||
There was a problem hiding this comment.
A few little things:
- Only one space after a period
- Recommend using parameter substitutions in the string and passing in either
nameof(Foo)or whatever from within the code. - The term "SQL" should be in all caps.
There was a problem hiding this comment.
addressing 2. this is expected to be a static message, I don't expect anything to change, but I can parameterize the names of the log levels if you think that is necessary
There was a problem hiding this comment.
It makes it easier for the localizers if every bit of the string is actually localizable text. That way we don't have to "lock out" strings to prevent them from being overlocalized.
lukewaters
force-pushed
the
debugLogging
branch
2 times, most recently
from
60e7841 to
c476c57
Compare
|
@Eilon I've parameterized the values that I don't think we should localize, does this look good? |
|
|
(sorry for delay, was on vacation)
lukewaters
force-pushed
the
debugLogging
branch
from
c476c57 to
6a83dfc
Compare
Using the new 'debug' level in logging, this adds the ability to EF to log query parameters
lukewaters
force-pushed
the
debugLogging
branch
from
6a83dfc to
a24c495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue #1374