Query: Cast result of IndexOf appropriately for SqlServer #19314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/indexof
branch
from
ee5e17b
to
6b40882
Compare
| SqlExpression charIndexExpression; | ||
| var storeType = stringTypeMapping.StoreType; | ||
| if (string.Equals(storeType, "nvarchar(max)", StringComparison.OrdinalIgnoreCase) | ||
| || string.Equals(storeType, "varchar(max)", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
We probably should delegate some of this to the type mapping to make this more robust. Perhaps part of #10434
There was a problem hiding this comment.
Delegating if it is max type? I would prefer to keep the logic of adding convert node in query only. A translation pipeline should know that when translating to a function, you may get back different types based on typeMapping of arguments.
AndriySvyryd
approved these changes
Dec 13, 2019
smitpatel
force-pushed
the
smit/indexof
branch
from
6b40882
to
79bdb47
Compare
smitpatel
force-pushed
the
smit/indexof
branch
from
79bdb47
to
daf8072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18772