Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Add indexed property support #19450

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Query: Add indexed property support #19450

merged 1 commit into from
Jan 4, 2020

Conversation

smitpatel
Copy link
Member

Part of #13610
Resolves #15799

@smitpatel smitpatel force-pushed the smit/backingfieldsindexer branch 2 times, most recently from 2a216b8 to 7d31196 Compare January 1, 2020 02:14
@smitpatel smitpatel changed the base branch from smit/backingfieldsindexer to master January 1, 2020 02:57
@smitpatel smitpatel force-pushed the smit/indexerquery branch 2 times, most recently from 8793087 to 3001079 Compare January 1, 2020 03:00
@smitpatel smitpatel marked this pull request as ready for review January 1, 2020 03:01
@smitpatel
Copy link
Member Author

Ready for review.

  • No tests for cosmos as Cosmos does not implement test from gears of war 😢
  • Adds basic queries we had in previous implementation, certainly we can expand more. We need to determine a strategy for query testing here. May be converting one of the property on Northwind to be indexer can give us existing tests.

@smitpatel smitpatel merged commit 769a462 into master Jan 4, 2020
@smitpatel smitpatel deleted the smit/indexerquery branch January 8, 2020 02:39
@ajcvickers ajcvickers mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: Index property support
2 participants
@smitpatel @AndriySvyryd