Fixes to TwoDatabasesTest #19707
Merged
Fixes to TwoDatabasesTest #19707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
added a commit
to roji/efcore.pg
that referenced
this pull request
Jan 25, 2020
…ontext Closes npgsql#1174 Following dotnet/efcore#8427 WIP: Tests are failing because of dotnet/efcore#19707
Capture connection strings including security info before it's gone (Persist Security Info=false)
roji
force-pushed
the
TwoDatabasesTestFixes
branch
from
80956f0
to
1bcad2f
Compare
ajcvickers
approved these changes
Jan 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in TwoDatabasesTest extract a connection string from a DbContext after its connection has been opened. This usually means that the password is scrubbed out when
Persist Security Info=false(the default), so the connection string is copied without it. The EF Core tests use LocalDB and Sqlite where there's no security info in the connection string.Also made tests virtual.