[release/3.1] Query: Match memberInfo in hierarchy for reducing MemberInitExpression #20047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: For compiler generated trees the MemberInfos always in sync. But for manually generated trees, if derived type parameter is used then the MemberInfo.ReflectedType is different. Which throws off ReplacingExpressionVisitor when comparing MemberInfo. Fix: Use helper method IsSameAs which compare memberInfos which refer to same member access in given hierarchy Resolves #19087
smitpatel
changed the title
|
@smitpatel Quirk? |
|
@smitpatel in the future please do not merge anything into release branches without confirmation that branches are open - this is for 3.1.4, which is shipping in May, but we currently are still working on 3.1.3 which ships in March. Merging early can risk resetting an in-progress build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: For compiler generated trees the MemberInfos always in sync. But for manually generated trees, if derived type parameter is used then the MemberInfo.ReflectedType is different. Which throws off ReplacingExpressionVisitor when comparing MemberInfo.
Fix: Use helper method IsSameAs which compare memberInfos which refer to same member access in given hierarchy
Resolves #19087
Customer Impact
In dynamic query generation if hierarchies are involved then it could throw translation failure error. It is hard to figure out the root cause for such cases.
How found
Multiple customer reported.
Test coverage
We have added test to cover this scenario.
Regression?
Yes, from 2.x
Risk
Low.