Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linux build breaks #20450

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Fix Linux build breaks #20450

merged 1 commit into from
Mar 28, 2020

Conversation

ajcvickers
Copy link
Member

Fix two issues building and testing on Linux introduced by #20304 (bad generated SQL for DefaultValue with line breaks /cc @lajones)

  • Test literals were using machine line endings
  • Replacement mechanism for new lines in literals did not handle a single \n

Fixes #20439
Fixes #20438

@ajcvickers
Fix Linux build breaks
6436169 
Fix two issues building and testing on Linux introduced by #20304 (bad generated SQL for DefaultValue with line breaks /cc @lajones)
* Test literals were using machine line endings
* Replacement mechanism for new lines in literals did not handle a single `\n`

Fixes #20439
Fixes #20438
@ajcvickers ajcvickers requested a review from a team March 28, 2020 21:05
@lajones
Copy link
Contributor

lajones commented Mar 28, 2020 •
edited
Loading

Well that's ironic 😀 . Sorry for the problem. Wonder why the Helix tests didn't catch it before I merged?

@ajcvickers
Copy link
Member Author

@lajones It's because the Helix tests build on Windows and then run on Linux.

@ajcvickers ajcvickers merged commit 01beb88 into master Mar 28, 2020
@ajcvickers ajcvickers deleted the FeedingLinesToTheReturningCarriage0328 branch March 28, 2020 21:59
@ajcvickers ajcvickers mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lajones lajones lajones approved these changes

@maumar maumar maumar approved these changes

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ajcvickers @lajones @smitpatel @maumar