Query: The true many to many testing model #20519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/M2MBegins
branch
from
da308ae
to
6b494d2
Compare
maumar
reviewed
Apr 3, 2020
test/EFCore.Specification.Tests/TestModels/ManyToManyModel/ManyToManyData.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Apr 3, 2020
| new EntityLeaf { Id = 18, Name = "Leaf 2", Number = 421, IsGreen = true }, | ||
| new EntityLeaf { Id = 19, Name = "Leaf 3", Number = 1337, IsGreen = false }, | ||
| new EntityLeaf { Id = 20, Name = "Leaf 4", Number = 1729, IsGreen = false }, | ||
| new EntityLeaf { Id = 21, Name = "Leaf 1", Number = 42, IsGreen = true }, |
There was a problem hiding this comment.
0x are root
1x are branch
2x are leaf
Many of the M2Ms were between derived types but they still used root type even though that becomes invalid relationship.
There was a problem hiding this comment.
Ah, I didn't set the offset so the leaves array index would be rolled from 0-3 rather than 15-19
maumar
approved these changes
Apr 3, 2020
smitpatel
force-pushed
the
smit/M2MBegins
branch
from
6b494d2
to
ed309bf
Compare
AndriySvyryd
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.