Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Populate __jObject on SaveChanges #20661

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Cosmos: Populate __jObject on SaveChanges #20661

merged 2 commits into from
Apr 17, 2020

Conversation

IGx89
Copy link
Contributor

@IGx89 IGx89 commented Apr 16, 2020

  • Store the document that Cosmos returns after Create and Replace operations onto the __jObject shadow property, ensuring it always exists after a database operation (previously it would only exist after queries)
  • Use instead of ignore the value of the __jObject shadow property on entity adds, allowing untracked properties to be populated on new entities before they're added.

Resolves #17778

@dnfclas
Copy link

dnfclas commented Apr 16, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AndriySvyryd AndriySvyryd self-assigned this Apr 16, 2020
@AndriySvyryd AndriySvyryd merged commit 3bc1894 into dotnet:master Apr 17, 2020
@AndriySvyryd
Copy link
Member

Thanks for your contribution!

@ajcvickers ajcvickers mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees

@AndriySvyryd AndriySvyryd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cosmos: Populate __jObject on SaveChanges
3 participants
@IGx89 @dnfclas @AndriySvyryd