Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test JSON serialization of EF object graphs #20827

Merged
merged 1 commit into from
May 31, 2020
Merged

Test JSON serialization of EF object graphs #20827

merged 1 commit into from
May 31, 2020

Commits on May 31, 2020

  1. Test JSON serialization of EF object graphs 

    Fixes #20548

Added tests that serialize graphs with both the BCL Json support and Newtonsoft.Json.

Findings:
*  BCL Json
  * Preserving references working fine; needed to increase max-depth for heavily nested graph, but exception message was clear
  * Lack of an Ignore option may be missed because output is harder to understand when it contains many internal references. Will follow up on this.
* Newtonsoft.JSON
  * Found it easy to get out-of-memory errors even when ignoring cycles
  * Got stack overflow errors when attempting to serialize cycles instead of ignoring them
  * I'm probably not configuring things correctly here, but this isn't high priority
* Net Topology Suite types are not JSON-serialization-friendly; will follow up on this
    @ajcvickers
    ajcvickers committed May 31, 2020
    Configuration menu
    Copy the full SHA
    5b0f068 View commit details
    Browse the repository at this point in the history