[master] Update dependencies from dotnet/arcade

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

• Subscription: 4ebe67d7-d53d-4b27-d461-08d76e1d3434
• Build: 20200528.4
• Date Produced: 5/28/2020 4:10 PM
• Commit: 96c65ad967d2abbbd8e770ba752a6b64255ec669
• Branch: refs/heads/master
• Updates:
  • Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20261.9 to 5.0.0-beta.20278.4
  • Microsoft.DotNet.Helix.Sdk: from 5.0.0-beta.20261.9 to 5.0.0-beta.20278.4

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: efcore-ci, efcore-ci (Build Helix)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
• ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

[BrennanConroy]

@smitpatel Is EF relying on an SDK/Runtime version just being on the Helix machines? I don't see any logic to install specific versions.

Arcade is now updating SDK versions in global.json (don't think it did this before).

Helix error:

It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '5.0.0-preview.6.20264.1' was not found.
  - The following frameworks were found:
      5.0.0-preview.5.20230.9 at [C:\h\w\B56A0A09\p\dotnet\shared\Microsoft.NETCore.App]

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: efcore-ci, efcore-ci (Build Helix)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
• ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

[smitpatel]

This line needs to be updated. https://github.com/dotnet/efcore/blob/master/eng/helix.proj#L11

[BrennanConroy]

Awesome, thanks I'll update

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❓ Waiting on checks: efcore-ci, efcore-ci (Build Helix)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
• ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

[dougbu]

@BrennanConroy FYI

don't think it did this before

Yes, it's done this before and we've had to make the same change in the past. @dotnet/efcore why are you fine with Helix tests breaking on every SDK update (whether Arcade-inspired or not)? Long-term fix would be something like what @HaoK did in dotnet/aspnetcore to get the right SDK version to the Helix agents.

@HaoK I've seen that code but can't point to it at the moment. Can you lead the way?

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❓ Waiting on checks: efcore-ci, efcore-ci (Build Helix)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
• ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

[HaoK]

We do things differently in aspnet, EFCore is using the built in xunit support so they are tied to the sdk version, we use $(NETCoreSdkVersion) in our builds. But our test runner manually downloads specific sdk and runtime builds. Once helix ingests some of fowler's improvements, we will probably switch to relying on the sdk support built into helix as well, and then we'd just set DotNetCliVersion to $(NETCoreSdkVersion) on the aspnetcore builds

[dotnet-maestro]

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

• ✔️ Standard Merge Policies Succeeded - Successful checks: efcore-ci, efcore-ci (Build Linux), efcore-ci (Build Helix), efcore-ci (Build Windows), efcore-ci (Build macOS), build
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
• ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

[smitpatel]

@dougbu - We only update SDK once a preview version (that would be once a month only), hence we don't think it is too much of burden to update both of the places together. We are not opposed to having SDK take value directly in helix if it is there in some variable. Due to low cost to us, we haven't prioritized doing that work. If you want to contribute a PR, we would happy to take it.