Fix to #18147 - Where bool column needs to convert to equality when value converter is applied #21144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
commented
Jun 5, 2020
maumar
commented
Jun 5, 2020
maumar
commented
Jun 5, 2020
smitpatel
reviewed
Jun 5, 2020
smitpatel
reviewed
Jun 5, 2020
src/EFCore.Cosmos/Query/Internal/CosmosValueConverterCompensatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jun 5, 2020
src/EFCore.Cosmos/Query/Internal/CosmosValueConverterCompensatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
force-pushed
the
fix18147
branch
2 times, most recently
from
2a6b952
to
39a1de7
Compare
ilmax
reviewed
Jun 6, 2020
smitpatel
reviewed
Jun 11, 2020
src/EFCore.Relational/Query/Internal/ValueConverterCompensatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
requested changes
Jun 15, 2020
src/EFCore.Cosmos/Query/CosmosQueryTranslationPostprocessorDependencies.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Cosmos/Query/Internal/CosmosValueConverterCompensatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/Internal/ValueConverterCompensatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
…alue converter is applied Added a postprocessor step that identifies bool columns with value converters inside a predicate and modifies them accordingly. Fixes #18147
smitpatel
approved these changes
Jun 17, 2020
|
@maumar - This PR failed on Cosmos build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a postprocessor step that identifies bool columns with value converters inside a predicate and modifies them accordingly.
Fixes #18147