Fix to #18871 - Support for indirect joins which are using non-equal conditions #21397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jun 24, 2020
test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
Outdated
Show resolved
Hide resolved
maumar
force-pushed
the
fix18871
branch
5 times, most recently
from
9ebb318
to
1b90184
Compare
|
updated @smitpatel |
maumar
force-pushed
the
fix18871
branch
2 times, most recently
from
ff035c0
to
4967bc0
Compare
smitpatel
reviewed
Jun 29, 2020
smitpatel
reviewed
Jun 29, 2020
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindSelectQuerySqlServerTest.cs
Show resolved
Hide resolved
|
updated |
|
@smitpatel ping |
|
Conflicts? |
|
@smitpatel resolved |
- ef_negate - ef_add - ef_divide - ef_multiply - ef_subtract by ef_add and negated subtrahend
smitpatel
approved these changes
Jul 9, 2020
…conditions When validating join key expression we now allow non-equality binary ops. Fixes #18871
|
But you did not let windows test run fully. 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating join key expression we now allow non-equality binary ops on the top level.
Fixes #18871