Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny: correct translation failure message #21408

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Tiny: correct translation failure message #21408

merged 1 commit into from
Aug 21, 2020

Conversation

roji
Copy link
Member

@roji roji commented Jun 24, 2020

No description provided.

@roji roji requested a review from a team June 24, 2020 23:40
@smitpatel
Copy link
Member

Tests?

@roji
Copy link
Member Author

roji commented Jun 24, 2020

Does not seem valuable enough...

@smitpatel
Copy link
Member

There should be at least one test somewhere.

@smitpatel
Copy link
Member

There are already tests which are failing. :trollface:

@roji
Copy link
Member Author

roji commented Jun 25, 2020

Then my work is done.

(will look)

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main July 23, 2020 04:35
@roji roji force-pushed the MethodTranslationFailureMessage branch from bb3b771 to 59d63b8 Compare August 21, 2020 15:12
@roji roji changed the base branch from main to release/5.0 August 21, 2020 15:18
@roji roji requested a review from dougbu as a code owner August 21, 2020 15:18
@roji roji force-pushed the MethodTranslationFailureMessage branch from 59d63b8 to e4e215c Compare August 21, 2020 15:20
@roji roji requested a review from smitpatel August 21, 2020 15:53
@roji roji merged commit b6877e7 into release/5.0 Aug 21, 2020
@roji roji deleted the MethodTranslationFailureMessage branch August 21, 2020 19:33
@ajcvickers ajcvickers mentioned this pull request Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roji @smitpatel