Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hacky mappings for SQL types that only work on .NET Framework #21596

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Remove hacky mappings for SQL types that only work on .NET Framework #21596

merged 1 commit into from
Jul 13, 2020

Conversation

ajcvickers
Copy link
Member

Fixes #20442

@ajcvickers ajcvickers requested a review from bricelam July 11, 2020 22:50
@ajcvickers
Copy link
Member Author

@bricelam Double checking here that this won't break any third-party things we know of?

@bricelam
Copy link
Contributor

It might have theoretically been possible on .NET Core, but haven’t seen anyone actually trying it. Nothing they can’t just create an extension for if they really need it.

@ajcvickers ajcvickers merged commit 04ddbda into master Jul 13, 2020
@ajcvickers ajcvickers deleted the ClimbingDown0711 branch July 13, 2020 20:41
@ajcvickers ajcvickers mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove half-baked SqlHierarchyId code that requires .NET Framework
2 participants
@ajcvickers @bricelam