Preiew 8: Remove non-named shared type ModelBuilder overloads #21739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on API reviews we decided that we don't want to ship these overloads in 5.0. Ideally they belong in model pre-configuration, which we hope to implement in 6.0, so removing them from here now.
ajcvickers
changed the title
smitpatel
reviewed
Jul 22, 2020
smitpatel
reviewed
Jul 22, 2020
AndriySvyryd
approved these changes
Jul 22, 2020
| /// <param name="model"> The model to add the shared type to. </param> | ||
| /// <param name="clrType"> The type of the entity type that should be shared. </param> | ||
| /// <param name="fromDataAnnotation"> Indicates whether the configuration was specified using a data annotation. </param> | ||
| public static Type AddShared([NotNull] this IConventionModel model, [NotNull] Type clrType, bool fromDataAnnotation = false) |
There was a problem hiding this comment.
I don't think that we decided to remove the Metadata API as well
There was a problem hiding this comment.
I added them back in #21741
There was a problem hiding this comment.
I removed them because they weren't being called by anything but the fluent API, but fine to add them back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on API reviews we decided that we don't want to ship these overloads in 5.0. Ideally they belong in model pre-configuration, which we hope to implement in 6.0, so removing them from here now.