Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Add logging #21924

Merged
1 commit merged into from
Aug 4, 2020
Merged

Query: Add logging #21924

1 commit merged into from
Aug 4, 2020

Conversation

smitpatel
Copy link
Member

Part of #17498

Added messages

  • Starting query compilation
  • Navigation included
  • Skip/Take without order by (infra is in core but providers use to generate the warning)
  • First without order by or predicate (infra is in core but providers use to generate the warning)

Removed messages

  • Include ignored (they get removed due to automatic pruning based on expression tree visitation
  • Obsolete exception with aggregate operator in relational. We logged that when doing client eval of aggregate operation
  • Optimized query model - there is no more optimization phase.

Other fixes

  • Don't log parameter values in Cosmos when sensitive data logging is not enabled.

@smitpatel smitpatel requested a review from a team August 4, 2020 00:52
Part of #17498

Added messages
- Starting query compilation
- Navigation included
- Skip/Take without order by (infra is in core but providers use to generate the warning)
- First without order by or predicate  (infra is in core but providers use to generate the warning)

Removed messages
- Include ignored (they get removed due to automatic pruning based on expression tree visitation
- Obsolete exception with aggregate operator in relational. We logged that when doing client eval of aggregate operation
- Optimized query model - there is no more optimization phase.

Other fixes
- Don't log parameter values in Cosmos when sensitive data logging is not enabled.
@smitpatel
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Aug 4, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 4, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit fb41d0e into main Aug 4, 2020
@ghost ghost deleted the smit/logs branch August 4, 2020 05:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants