Make required dependent columns in shared table non-nullable. #21952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Aug 6, 2020
smitpatel
reviewed
Aug 6, 2020
| @@ -3540,6 +3585,13 @@ public virtual void ForeignKey_deleteBehavior_is_stored_in_snapshot_for_one_to_o | |||
| .HasForeignKey(""Microsoft.EntityFrameworkCore.Migrations.ModelSnapshotSqlServerTest+EntityWithOneProperty"", ""Id"") | |||
| .OnDelete(DeleteBehavior.Cascade) | |||
| .IsRequired(); | |||
|
|
|||
| b.Navigation(""EntityWithTwoProperties""); | |||
There was a problem hiding this comment.
Should we avoid empty navigation calls?
There was a problem hiding this comment.
It's hard to do with the way the code is structured. Usually we don't mind unnecessary calls in the snapshot because no one should look at it. But I'll let @bricelam make a call here.
There was a problem hiding this comment.
File an issue. Fine for 5.0
smitpatel
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12100