Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng: Do not generate redundant ColumnName/Type in fluent API #22173

Merged
1 commit merged into from
Aug 22, 2020

Conversation

smitpatel
Copy link
Member

Resolves #22122

Added full code coverage on CSharpEntityTypeGenerator. (Yes, it is soooo boring, so I will do DbContext one some other day)

Filed #22170 For ValueGenerated part.

@smitpatel smitpatel requested a review from a team August 21, 2020 22:41
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Yay, more coverage!

@ghost
Copy link

ghost commented Aug 21, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 8d09961 into release/5.0 Aug 22, 2020
@ghost ghost deleted the smit/scaffoldingissues branch August 22, 2020 00:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaffolding with --data-annotations emits redundant model configuration in OnModelCreating
2 participants