[5.0-rc2] RevEng: Remove ColumnType annotation from scaffolded code #22550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Pilchie @ajcvickers |
ajcvickers
approved these changes
Sep 16, 2020
|
@smitpatel Approved by Tactics for RC2. |
Since we put fluent API
smitpatel
force-pushed
the
smit/scaffolding
branch
from
0121136
to
8177f31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22564
Description
This is a regression from 3.1 found by a customer using RC1. We scaffold the appropriate method call to set the column type, but then also explicitly add the underlying annotation.
Customer Impact
This will impact a large majority of migrations generated by customers. While it does not cause a functional break, we would like to avoid thousands of customers getting this redundant code in their apps.
How found
Found in customer repro
Test coverage
New tests included in PR. This is also an area where we recognize that we need more testing; this is planned for MQ.
Regression?
Yes. Regression from 3.1
Risk
Low. Just remove redundant annotation.