[5.0.0-rc2] Add null checks to account for owned types in TPT #22587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Sep 17, 2020
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22576
Description
This is a bug in a new feature. In scenarios with more than 2 levels of TPT with an owned type defined on a derived type some methods will return
nullthat we haven't accounted for.Customer Impact
It's hard to estimate how many customers will be impacted, but given the location in the code path it's likely to affect other TPT scenarios apart from the one described above.
How found
Customer reported on RC1.
Test coverage
We were lacking test coverage for complex TPT models. This PR adds a test for the affected scenario.
Regression?
No, new feature in 5.0.
Risk
Low. Code changes just add
nullchecks.