Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter CI to run Rich Navigation, add new Rich Nav specific pipeline #22964

Merged
merged 5 commits into from
Oct 20, 2020

Conversation

jepetty
Copy link
Contributor

@jepetty jepetty commented Oct 12, 2020

I've altered two files:

  1. Add a Rich Navigation specific build (which will appear as a new build pipeline), indexing on every push to master. This will allow you to use Rich Navigation in Visual Studio to enable cross-repository searches, serverless navigation at https://online.visualstudio.com/github/dotnet/msbuild, and integrated GitHub C# navigation once that is released (or, comment below if you want to be added to the preview now 😊).
  2. Added the Rich Navigation task to your normal CI. This has all the same benefits of ^, but also indexes your pull requests for a richer code review experience. This does come at the cost of increasing the time of your CI.

Based on your team's preference, only one of these changes is necessary.

Rich Code Navigation

Docs Link
With Rich Code Navigation, you can use editor-level navigation capabilities (like peek definition, find all references, and even diagnostics) on a pull request, without requiring a local checkout. This is available across all files and dependencies of your repository.

Rich Code Navigation is available for Visual Studio (for repos hosted on GitHub or Azure Repos) and Visual Studio Code (for repos hosted on GitHub).

Rich Code Navigation supports these capabilities:

  • Hover
  • Peek definition and Go to definition
  • Peek references and Find all references
  • Go to type definition
  • Go to implementation
  • Diagnostics

@jepetty jepetty requested a review from dougbu as a code owner October 13, 2020 20:15
azure-pipelines-richnav.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
eng/common/templates/job/job.yml Outdated Show resolved Hide resolved
@roji
Copy link
Member

roji commented Oct 19, 2020

and integrated GitHub C# navigation once that is released (or, comment below if you want to be added to the preview now blush).

Am personally definitely interested in this 😃

@jepetty
Copy link
Contributor Author

jepetty commented Oct 20, 2020

Please ignore my latest hack-tacular commit replacing the normal CI with the Rich Nav pipeline. I'm doing this purely for testing purposes and will undo the changes once I've verified the pipeline runs successfully

@jepetty
Copy link
Contributor Author

jepetty commented Oct 20, 2020

I've removed my hack-tacular commit to replace the normal CI, but not before verifying the rich nav pipeline will run correctly: https://dev.azure.com/dnceng/public/_build/results?buildId=860052&view=logs&j=0bc77094-9fcd-5c38-f6e4-27d2ae131589&t=0bc77094-9fcd-5c38-f6e4-27d2ae131589. This PR is good to merge, then I'll create a new pipeline in dnceng

@dougbu
Copy link
Member

dougbu commented Oct 20, 2020

@smitpatel I defer to you on whether the EF Core team needs or wants the extra clickability in PRs. If not, merge away 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants