Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to #21393 - Query: Convert to AssertQuery in tests as much as possible #22994

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Fix to #21393 - Query: Convert to AssertQuery in tests as much as possible #22994

merged 1 commit into from
Oct 20, 2020

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Oct 14, 2020

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it

  • when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
  • ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
  • ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393

@maumar maumar requested a review from smitpatel October 14, 2020 03:43
@maumar
Copy link
Contributor Author

maumar commented Oct 14, 2020 •
edited
Loading

/cc @roji - some minor changes to test infra that might affect/break npgsql tests

@maumar
Copy link
Contributor Author

maumar commented Oct 17, 2020

@smitpatel updated

@maumar maumar force-pushed the fix21393_take2 branch 3 times, most recently from 7401b7e to 46a746e Compare October 19, 2020 22:33
@maumar
Copy link
Contributor Author

maumar commented Oct 19, 2020

updated

@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
58bcdd5 
…sible

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it
- when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
- ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
- ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393
@maumar maumar merged commit 58bcdd5 into main Oct 20, 2020
@maumar maumar deleted the fix21393_take2 branch October 20, 2020 19:59
@smitpatel
Copy link
Member

But build? 😮

@ajcvickers ajcvickers mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd left review comments

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: Convert to AssertQuery in tests as much as possible
3 participants
@maumar @smitpatel @AndriySvyryd