Use shared-type entity types instead of entity types with defining navigation. #23586
Conversation
| @@ -322,11 +253,6 @@ public virtual void UpdateIsKeylessConfigurationSource(ConfigurationSource confi | |||
| return newBaseType; | |||
| } | |||
|
|
|||
| if (HasDefiningNavigation()) | |||
There was a problem hiding this comment.
Does this enable former entity type with defining navigations to have hierarchy?
There was a problem hiding this comment.
Technically you can specify a base type for a STET, but we don't have Fluent API for it, nor support
| ?? (entityType.HasSharedClrType | ||
| ? entityType.FindOwnership() is ForeignKey ownership | ||
| ? FindActualEntityType(ownership.PrincipalEntityType) | ||
| ?.FindNavigation(ownership.PrincipalToDependent!.Name)?.TargetEntityType |
There was a problem hiding this comment.
💡 If FK has flag for ownership then may be can annotate that PrincipalToDependent is non-null when flag is true.
There was a problem hiding this comment.
There was a problem hiding this comment.
If I put [CA.MemberNotNullWhen(true, nameof(PrincipalToDependent))] on IsOwnership it doesn't help even if I use entityType.GetForeignKeys().FirstOrDefault(fk => fk.IsOwnership) instead of entityType.FindOwnership. I don't think the compiler is smart enough
test/EFCore.InMemory.FunctionalTests/Query/ComplexNavigationsSharedQueryInMemoryTest.cs
Outdated
Show resolved
Hide resolved
…vigation. They should behave mostly the same, except that DefiningEntityType and DefiningNavigationName will return true and Name will return what FullName returned previously Fixes #22378
AndriySvyryd
force-pushed
the
Issue22378
branch
from
4246590
to
3d31f53
Compare
test/EFCore.InMemory.FunctionalTests/Query/ComplexNavigationsWeakQueryInMemoryFixture.cs
Outdated
Show resolved
Hide resolved
They should behave mostly the same, except that
DefiningEntityTypeandDefiningNavigationNamewill returnnullandNamewill return whatFullNamereturned previously.Fixes #22378