[5.0.3] Flow through the column types in MigrationBuilder.InsertData #23614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndriySvyryd I assume |
|
Tactics would like us to wait for more customer reports on this one given that this, "only affects new API that is seldomly used." |
Ok. Any time it's used it will fail. |
|
@AndriySvyryd If we get more customer reports we can take it in the next patch. |
|
@ajcvickers That's fine, I'm not pushing back |
bricelam
approved these changes
Dec 8, 2020
AndriySvyryd
changed the title
AndriySvyryd
force-pushed
the
Issue23503
branch
from
d8ab3a3
to
410c551
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23503
Note for Tactics
This was rejected for 5.0.2 due to concerns that it might not impact many customers. We now have multiple customer reports (4+) so we're brining it back for 5.0.3.
Description
MigrationBuilder.InsertDatawas not passing through the column types parameter to the underlying method.Customer Impact
Creating a migration that adds data to a table that is not mapped in the model will fail. The workaround would be to use internal API.
How found
Customer reported on 5.0.0.
Test coverage
We have added more test coverage in this PR.
Regression?
No, this overload of
InsertDatais new in 5.0Risk
Low. Only affects new API that is seldomly used.