Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable flaky CI tests on SqlServer on Ubuntu #23706

Merged
1 commit merged into from
Dec 16, 2020
Merged

Re-enable flaky CI tests on SqlServer on Ubuntu #23706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/EFCore.SqlServer.FunctionalTests/DbContextPoolingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,6 @@ public async Task Provider_services_are_reset_with_factory(bool async)
[ConditionalTheory]
[InlineData(true)]
[InlineData(false)]
[PlatformSkipCondition(TestPlatform.Linux, SkipReason = "Test is flaky on CI.")]
public void Double_dispose_concurrency_test(bool useInterface)
{
var serviceProvider = useInterface
Expand Down Expand Up @@ -1091,7 +1090,6 @@ public void Double_dispose_concurrency_test(bool useInterface)
[InlineData(true, false)]
[InlineData(false, true)]
[InlineData(true, true)]
[PlatformSkipCondition(TestPlatform.Linux, SkipReason = "Test is flaky on CI.")]
public async Task Concurrency_test(bool useInterface, bool async)
{
PooledContext.InstanceCount = 0;
Expand Down
2 changes: 0 additions & 2 deletions test/EFCore.SqlServer.FunctionalTests/SequenceEndToEndTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Microsoft.EntityFrameworkCore
public class SequenceEndToEndTest : IDisposable
{
[ConditionalFact]
[PlatformSkipCondition(TestPlatform.Linux, SkipReason = "Test is flaky on CI.")]
public void Can_use_sequence_end_to_end()
{
var serviceProvider = new ServiceCollection()
Expand Down Expand Up @@ -183,7 +182,6 @@ await context.AddAsync(
}

[ConditionalFact]
[PlatformSkipCondition(TestPlatform.Linux, SkipReason = "Test is flaky on CI.")]
public async Task Can_use_sequence_end_to_end_from_multiple_contexts_concurrently_async()
{
var serviceProvider = new ServiceCollection()
Expand Down