Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IAnnotatable and IModel extension methods to the interfaces #24089

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Move IAnnotatable and IModel extension methods to the interfaces #24089

merged 1 commit into from
Feb 12, 2021

Conversation

AndriySvyryd
Copy link
Member

Part of #19213

@AndriySvyryd AndriySvyryd requested a review from a team February 8, 2021 20:43
@AndriySvyryd AndriySvyryd changed the title Move IReadOnlyAnnotatable and IReadOnlyModel extension methods to the interfaces Move IAnnotatable and IModel extension methods to the interfaces Feb 9, 2021
@smitpatel
Copy link
Member 

    public static void SetProductVersion([NotNull] this IMutableModel model, [NotNull] string value)

Leaving these as extensions?

Refers to: src/EFCore/Metadata/Internal/ModelExtensions.cs:27 in 40f54ea. [](commit_id = 40f54ea, deletion_comment = False)

smitpatel
smitpatel approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AndriySvyryd
Copy link
Member Author

Leaving these as extensions?

Yes, shouldn't be used by outside code

@AndriySvyryd AndriySvyryd merged commit b708390 into main Feb 12, 2021
@AndriySvyryd AndriySvyryd deleted the Issue19213_2 branch February 12, 2021 03:45
@ajcvickers ajcvickers mentioned this pull request Feb 25, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndriySvyryd @smitpatel