[automated] Merge branch 'release/5.0' => 'main' #24101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update to 5.0.3 SDK
- also update downlevel runtimes
ghost
added
the
dotnet-maestro-bot
force-pushed
the
merge/release/5.0-to-main
branch
from
09e8bad
to
c1527f1
Compare
|
Hello @msftbot[bot]! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…209.6 (dotnet#24103) [release/5.0] Update dependencies from dotnet/arcade
…or LeftJoin (dotnet#23984) Resolves dotnet#23926 Issue: - For TPH hierarchy, we generate conditional value read expression for derived property using ConditionalExpression - To check the right derived type we use value comparer on discriminator column in ConditionalExpression.Test - For enum discriminator the value comparer uses `object.Equals` methods which requires converting all args to object using UnaryExpression. (This could happen for non-enums too in some cases) - When reading right side of properties in left join we convert all of those read access to nullable which causes operand of unary to be nullable type. The base visitor does not allow this type change Hence we need to override the method and allow for conversion to happen since we expect it.
Fixes dotnet#23889 **Description** AddPooledDbContextFactory (new in 5.0) has a parameter to set the pool size. This value was not being passed down to lower-level config and hence the default pool size is always used. **Customer Impact** The pool size cannot be changed when using the 'AddDbContext' for a factory and pooling. **How found** Customer reported on 5.0. **Test coverage** The test factoring did not test the defaults or overridden values for pool size; this has been added. **Regression?** No; new feature in 5.0. **Risk** Very low.
|
@ajcvickers can you verify the contents of the merge? |
roji
previously approved these changes
Feb 12, 2021
smitpatel
reviewed
Feb 12, 2021
smitpatel
reviewed
Feb 12, 2021
src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
|
@roji can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected changes in the release/5.0 branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR.
This PR merges commits made on release/5.0 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/5.0-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.