Update SQL baselines #24459
Merged
Update SQL baselines #24459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/sqlupdates
branch
2 times, most recently
from
05e8b58
to
ad89d28
Compare
smitpatel
commented
Mar 20, 2021
| } | ||
|
|
||
| public override async Task SelectMany_with_navigation_and_Distinct(bool async) | ||
| { | ||
| await base.SelectMany_with_navigation_and_Distinct(async); | ||
|
|
||
| AssertSql( | ||
| @"SELECT [l].[Id], [l].[Date], [l].[Name], [t].[Id], [t].[OneToOne_Required_PK_Date], [t].[Level1_Optional_Id], [t].[Level1_Required_Id], [t].[Level2_Name], [t].[OneToMany_Optional_Inverse2Id], [t].[OneToMany_Required_Inverse2Id], [t].[OneToOne_Optional_PK_Inverse2Id], [t0].[Id], [t0].[OneToOne_Required_PK_Date], [t0].[Level1_Optional_Id], [t0].[Level1_Required_Id], [t0].[Level2_Name], [t0].[OneToMany_Optional_Inverse2Id], [t0].[OneToMany_Required_Inverse2Id], [t0].[OneToOne_Optional_PK_Inverse2Id], [t0].[Id0] | ||
| @"SELECT [l].[Id], [l].[Date], [l].[Name], [t].[Id], [t0].[Id], [t0].[OneToOne_Required_PK_Date], [t0].[Level1_Optional_Id], [t0].[Level1_Required_Id], [t0].[Level2_Name], [t0].[OneToMany_Optional_Inverse2Id], [t0].[OneToMany_Required_Inverse2Id], [t0].[OneToOne_Optional_PK_Inverse2Id], [t0].[Id0] |
There was a problem hiding this comment.
Valid change, Distinct over entity type preserving Id as identifier
| FROM [Customers] AS [c] | ||
| LEFT JOIN ( | ||
| SELECT [t].[OrderID], [t].[ProductID], [o].[OrderID] AS [OrderID0], [t].[OrderID] AS [OrderID1], [t].[ProductID] AS [ProductID0], [o].[CustomerID] | ||
| SELECT [t].[OrderID], [t].[ProductID], [o].[OrderID] AS [OrderID0], [o].[CustomerID] |
There was a problem hiding this comment.
Valid change. Earlier we did not match the columns correctly.
| @@ -1595,7 +1595,7 @@ public override async Task Projecting_after_navigation_and_distinct(bool async) | |||
| FROM [Orders] AS [o0] | |||
| WHERE [o0].[OrderID] IN (10248, 10249, 10250) AND (([t].[CustomerID] = [o0].[CustomerID]) OR ([t].[CustomerID] IS NULL AND [o0].[CustomerID] IS NULL)) | |||
| ) AS [t0] | |||
| ORDER BY [t].[CustomerID], [t].[Address], [t].[City], [t].[CompanyName], [t].[ContactName], [t].[ContactTitle], [t].[Country], [t].[Fax], [t].[Phone], [t].[PostalCode], [t].[Region], [t0].[OrderID]"); | |||
| ORDER BY [t].[CustomerID], [t0].[OrderID]"); | |||
There was a problem hiding this comment.
Valid change, since the PK is inside Distinct projection, we retain identifier rather than using whole projection.
smitpatel
force-pushed
the
smit/ABriefRevisitToGraphTheory
branch
2 times, most recently
from
f801da6
to
1d2cd44
Compare
smitpatel
force-pushed
the
smit/sqlupdates
branch
from
ad89d28
to
801bace
Compare
smitpatel
force-pushed
the
smit/ABriefRevisitToGraphTheory
branch
from
1d2cd44
to
7bc06e7
Compare
smitpatel
force-pushed
the
smit/sqlupdates
branch
from
801bace
to
203f408
Compare
smitpatel
force-pushed
the
smit/ABriefRevisitToGraphTheory
branch
from
7bc06e7
to
7ba85c7
Compare
smitpatel
force-pushed
the
smit/sqlupdates
branch
from
203f408
to
67e80e6
Compare
Part of #17337
smitpatel
force-pushed
the
smit/sqlupdates
branch
from
67e80e6
to
d4237ec
Compare
smitpatel
force-pushed
the
smit/ABriefRevisitToGraphTheory
branch
from
7ba85c7
to
fb3c5b8
Compare
maumar
reviewed
Mar 22, 2021
maumar
approved these changes
Mar 22, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17337