Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IScaffoldingModelFactory public #25094

Merged
1 commit merged into from
Jun 15, 2021
Merged

Make IScaffoldingModelFactory public #25094

1 commit merged into from
Jun 15, 2021

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jun 14, 2021

Fixes #23049

  • ❌ I've read the guidelines for contributing and seen the walkthrough
  • ❌ I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • ❔ The code builds and tests pass locally (also verified by our automated build checks)
  • ❌ Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • ❌ Tests for the changes have been added (for bug fixes / features)
  • ✔️ Code follows the same patterns and style as existing code in this repo

@bricelam bricelam requested a review from a team June 14, 2021 21:29
@bricelam
Copy link
Contributor Author

bricelam commented Jun 14, 2021

@AndriySvyryd Is there a reason the PR template isn't an HTML comment anymore? As you can see above, this broke my highly streamlined workflow. 😉 But since it showed up, I took the time to fill it out...

@ghost
Copy link

ghost commented Jun 14, 2021

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@AndriySvyryd
Copy link
Member

@bricelam This makes it clear whether the author actually read it.

@ghost
Copy link

ghost commented Jun 14, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 954da6f into dotnet:main Jun 15, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make IScaffoldingModelFactory public
3 participants