Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip and warn of duplicated SQL Server foreign keys #25378

Merged
merged 13 commits into from
Aug 10, 2021
Merged

Skip and warn of duplicated SQL Server foreign keys #25378

merged 13 commits into from
Aug 10, 2021

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Jul 31, 2021

fixes #25197

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jul 31, 2021

Wauw, the logging is complex and so full of magic stuff.

@smitpatel smitpatel requested a review from bricelam August 2, 2021 14:48
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Aug 8, 2021

@bricelam any chance to get this into 6.0??

@smitpatel
Copy link
Member

@ErikEJ - This will get into 6.0. I will merge this by Wednesday (or earlier) so it is in next preview version.

@smitpatel smitpatel merged commit 159c7e7 into dotnet:main Aug 10, 2021
@smitpatel
Copy link
Member

Thanks @ErikEJ

@ajcvickers ajcvickers mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@bricelam bricelam Awaiting requested review from bricelam

Assignees

@smitpatel smitpatel

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unblocking duplicate foreign keys when reverse engineering an existing database (SQL Server)
2 participants
@ErikEJ @smitpatel