[6.0-rc2] Fix Fluent APIs on keys in model snapshot #26058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
roji/KeyFluentAPIs
branch
from
8ecf704
to
28216ac
Compare
Also generate Fluent API for IsMemoryOptimized. Fixes #26045
ajcvickers
force-pushed
the
roji/KeyFluentAPIs
branch
from
28216ac
to
ed1bce8
Compare
ajcvickers
approved these changes
Sep 16, 2021
|
@roji Please fill out the servicing template above. |
|
@ajcvickers done |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@roji Helix is broken again. I ran this PR locally and everything passed. |
|
@ajcvickers oh ok, thanks. Do I need to wait for approval from outside the team or can we still merge as usual? |
ajcvickers
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We're close enough to the RC2 snap that I'll approve merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26045
Description
Invalid migrations snapshot generated for key Fluent APIs
Customer Impact
Generated migrations which contain Fluent API configurations for keys (e.g. clustered) do not compile. Discovered by customer on RC1.
How found
User report: #26045 trying RC1
Test coverage
Added as part of this PR
Regression?
Yes, introduced as part of recent improvements to migration code generation.
Risk
Low, the issue is simple, the fix is well-understood, and the area is relatively well-covered.
Also generate Fluent API for IsMemoryOptimized.
@Pilchie @dotnet/efteam - This fixes a bug reported on rc1, and needs to go into rc2.